Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert the force quit dialog to a cinnamon dialog #12408

Merged
merged 3 commits into from
Oct 2, 2024

Conversation

JosephMcc
Copy link
Contributor

No description provided.

We need this for the force-close dialog. It will be included in the
MetaWindowGroup, but needs to tracked as chrome to recieve pointer
events
With the new dialogs and theming in place we can start looking at converting
some of these away from Gtk dialogs
Gtk dialogs have the action on the right so move the Force Quit button to the
right side to match the layout users are accustomed to
@anaximeno
Copy link
Contributor

anaximeno commented Sep 25, 2024

Hello @JosephMcc, does this PR fix the issue below as well?

Untitled
pic. - force quit dialog

That text in the list view was not getting the proper text theme according to the dark theme (which should be white I suppose), also I'm not sure if the translation is implemented for that (if it is possible).

@JosephMcc
Copy link
Contributor Author

Yes. It would no longer be a GTK dialog so that but would no longer be relevant.

@clefebvre
Copy link
Member

Hello @JosephMcc, does this PR fix the issue below as well?

Untitled pic. - force quit dialog

That text in the list view was not getting the proper text theme according to the dark theme (which should be white I suppose), also I'm not sure if the translation is implemented for that (if it is possible).

No, that's a different dialog. That's one of the session quit dialog.

@clefebvre clefebvre merged commit 4096ea2 into linuxmint:master Oct 2, 2024
3 checks passed
@Alstruit
Copy link

It appears that the force quit dialog does not read the keyboard inputs (Tab,Left/Right keys). This may cause an issue if the application hides the mouse cursor.

@JosephMcc
Copy link
Contributor Author

An oversight on my part. Hope to PR a fix in the next day or two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants